search

redhat-developer / redhat-helm-charts

This repository contains the Helm charts that power charts in the OpenShift Developer Catalog
Apache License 2.0
49 stars 84 forks source link

Order Management Form-based Values Testing #27

Closed ntinvo closed 4 years ago

ntinvo commented 4 years ago

Testing new OCP 4.6 features for Order Management helm chart changes. Added values.schema.json for form-based values charts with schema. https://issues.redhat.com/browse/ODC-2993 - Form-based values for charts with schema

sbose78 commented 4 years ago

Could you update the PR description with a message on why this change is being made?

sbose78 commented 4 years ago

Did you intend to put them in "alpha"? Or do you think they should be in "stable"?

ntinvo commented 4 years ago

@sbose78 yes, the chart is not stable so I did intend to put it in the alpha dir for testing the new form-based values charts.

ntinvo commented 4 years ago

@sbose78 do I need to do anything else to get this merged? Thank you!

sbose78 commented 4 years ago

We are reviewing it, let me know if it's urgent or can wait a day?

ntinvo commented 4 years ago

It can wait a day! No worries. Thank you!

UPDATE: I'm closing this because we do not want external merge. Nancy will be helping us in testing the values.schema.json. Thank you and sorry for the confusion!