search

redhat-developer / redhat-helm-charts

This repository contains the Helm charts that power charts in the OpenShift Developer Catalog
Apache License 2.0
49 stars 83 forks source link

dotnet: need more information on chart support level #70

Open zonggen opened 3 years ago

zonggen commented 3 years ago

We are in the process of migrating this repository over to https://github.com/openshift-helm-charts/charts, and there are three vendor types for charts: partner, redhat and community. Initially dotnet chart is moved under redhat vendor type: https://github.com/openshift-helm-charts/charts/tree/main/charts/redhat/redhat/dotnet but we want to confirm with the chart owner that this chart is not a community chart. Quote from Hugo Rivero when discussing about differences between redhat vs community charts:

The main attribute for community are charts that are supported by a community and not covered by enterprise support. Community charts may come from Red Hatters, from partners (i.e. in their own upstream work). Charts that are in placed under Red Hat should be commercially supported, i.e. because they provide a supported installation method for a product or component.

If the chart is indeed a community chart, we'll move it from charts/redhat/ to charts/community/, everything else remains and works the same.

cc @tmds

tmds commented 3 years ago

I built this chart based on the Quarkus chart. Not much of it is .NET specific, so I don't expect there to be a big effort to officially support it.

Where are most of the charts that wrap s2i images going, under redhat or community?

I'll check with the others of our team.

cc @omajid @aslicerh

zonggen commented 3 years ago

Thank you for replying :smiley:. I see that Wildfly chart is using the s2i images and it goes to the community vendor type under https://github.com/openshift-helm-charts/charts/tree/main/charts/community.

tmds commented 3 years ago

Are you aware of s2i-based charts that are placed under redhat? Which ones? In general, we like .NET to be similarly supported as other runtimes.

As the chart gets moved, can we consider a few esthetic changes? This is how it looks now:

helm chart name

Change the name from Dotnet to .NET Chart?

Change the version from 0.0.1 to 1.0.0? 0.0.1 sounds like it likely to API break on the next release.

Use the .NET icon that (our s2i imagestreams have "iconClass": "icon-dotnet")? Though maybe there are UX reasons to keep the Helm icon?

zonggen commented 3 years ago

Looking through the charts under redhat and it seems like Quarkus also creates an s2i build. I've asked them the moving plans and waiting for their answer: https://github.com/redhat-developer/redhat-helm-charts/issues/69

About the name change, I will confirm with the ODC (OpenShift Dev Console) team whether it should be updated on the charts repository or on the frontend.

Version changes can happen naturally when the new chart (1.0.0) is submitted through a pull request: e.g. bump vault 0.14.0 to 0.15.0: https://github.com/openshift-helm-charts/charts/pull/302

For the icon issue, I will let the ODC team know. Though I did not find a "iconClass": "icon-dotnet" pair under the charts source directory. There is "icon": "" in the report.yaml that generated by the chart-verifier.

zonggen commented 3 years ago

There are two optional annotations in index.yaml that the console UI is picking up to render the catalog: charts.openshift.io/name and charts.openshift.io/provider:

We are planning to make charts.openshift.io/name mandatory and add checks tochart-verifier to make sure the displayed name is as desired.

xref: https://issues.redhat.com/browse/HELM-226

zonggen commented 2 years ago

@tmds To followup, would it be okay to put your GitHub ID into the OWNERS file of dotnet chart? In the new openshift-helm-charts repository we added OWNERS files for each chart in order to better keep track of ownerships (https://github.com/openshift-helm-charts/charts/blob/main/charts/redhat/redhat/dotnet/OWNERS#L6).

Note the name is currently @dperaza4dustbit (team lead for Helm team) but we would like to track the real owners.

tmds commented 2 years ago

charts.openshift.io/name: human readable chart name, ready to be displayed in UI

So, we can make this .NET?

To followup, would it be okay to put your GitHub ID into the OWNERS file of dotnet chart?

Yes, no problem.

@zonggen how will the UI show the difference between community and redhat charts?

zonggen commented 2 years ago

So, we can make this .NET?

We are actually working on making the charts.openshift.io/name a required annotation for redhat and partner charts and improving the displayed chart names this sprint: https://issues.redhat.com/browse/HELM-226

Submitted naming change here for the latest .NET chart: https://github.com/openshift-helm-charts/charts/pull/358

how will the UI show the difference between community and redhat charts?

This is in 4.9 Helm installation catelog, see the Community under "Source": image

tmds commented 2 years ago

@zonggen you can add the .NET chart to the community folder.