search

redhat-developer / redhat-helm-charts

This repository contains the Helm charts that power charts in the OpenShift Developer Catalog
Apache License 2.0
49 stars 84 forks source link

nodejs-ex-k: need more information on chart support level #72

Open zonggen opened 3 years ago

zonggen commented 3 years ago

We are in the process of migrating this repository over to https://github.com/openshift-helm-charts/charts, and there are three vendor types for charts: partner, redhat and community. Initially nodejs-ex-k chart is moved under redhat vendor type: https://github.com/openshift-helm-charts/charts/tree/main/charts/redhat/redhat/nodejs-ex-k but we want to confirm with the chart owner that this chart is not a community chart. Quote from Hugo Rivero when discussing about differences between redhat vs community charts:

The main attribute for community are charts that are supported by a community and not covered by enterprise support. Community charts may come from Red Hatters, from partners (i.e. in their own upstream work). Charts that are in placed under Red Hat should be commercially supported, i.e. because they provide a supported installation method for a product or component.

If the chart is indeed a community chart, we'll move it from charts/redhat/ to charts/community/, everything else remains and works the same.

cc @yselkowitz

yselkowitz commented 3 years ago

I am not the owner of this chart, my involvement is limited to multi-arch enablement, iow that the chart should work on all OpenShift architectures.

To that end, my concern with openshift-helm-charts is that many charts will reference images that are not available on all architectures, but the charts will show as available anyways. When unknowing users see those, try to install them, and then they fail, what will their reaction be? Is there any way to designate the architectures for which a chart is valid by which the console can filter accordingly?

Another thing I did note is that this chart uses ubi8/nodejs-10 which is out of support, it needs to be updated to a more recent version (preferably 14).

cc @hhorak who manages both the UBI8 nodejs images and the nodejs-ex repo used by this chart.

zonggen commented 3 years ago

Thank you for the quick reply. Thought it might be helpful to let @dperaza4dustbit and @slemeur aware of this.

zonggen commented 3 years ago

@hhorak To followup, would it be okay to put your GitHub ID into the OWNERS file of nodejs-ex-k chart? In the new openshift-helm-charts repository we added OWNERS files for each chart in order to better keep track of ownerships (https://github.com/openshift-helm-charts/charts/blob/main/charts/redhat/redhat/nodejs-ex-k/OWNERS#L6).

Note the name is currently @dperaza4dustbit (team lead for Helm team) but we would like to track the real owners.