search

redhat-developer / s2i-dotnetcore

.NET Core OpenShift images
Apache License 2.0
112 stars 192 forks source link

Specify dotnet configuration for dotnet test #462

Closed LvanLeeuwen closed 1 year ago

LvanLeeuwen commented 1 year ago

When specifying tests to run using DOTNET_TEST_PROJECTS they're by default executed with configuration=Debug while DOTNET_CONFIGURATION might be set to Release. Can you please also use the specified DOTNET_CONFIGURATION for the dotnet test command?

tmds commented 1 year ago

they're by default executed with configuration=Debug

For backwards compat we probably want to keep this behavior. We can add another envvar that controls the configuration for tests (DOTNET_TEST_CONFIGURATION).

Are you using .NET 6, .NET 7, or both?

cc @omajid @aslicerh

LvanLeeuwen commented 1 year ago

That sounds like a perfect solution! We're currently using .NET 6 and we'll move to .NET 8 after its official release.

aslicerh commented 1 year ago

The PR for this change has been merged. It should show up in the official images with the next .NET monthly release.