search

redhat-developer / s2i-dotnetcore

.NET Core OpenShift images
Apache License 2.0
112 stars 192 forks source link

Initial .NET 8.0 changes. #467

Closed tmds closed 1 year ago

tmds commented 1 year ago

Update Dockerfiles and tests so they pass against an rc1 tarball.

tmds commented 1 year ago

I've removed the Fedora Dockerfiles in this PR, as it seems we never made the 7.0 version use the packages instead of the 7.0 rc1 Microsoft tarball.

https://github.com/redhat-developer/s2i-dotnetcore/blob/477be53d2a135f674459f98df9fafd872a3e021f/7.0/runtime/Dockerfile.fedora#L53-L65

tmds commented 1 year ago

@aslicerh @omajid I will be merging these changes into the dev_80 branch tomorrow.

For previous releases, we had a separate dev branch mostly because it was referring to an upstream dotnet tarball in a hard-coded way. We're not doing this here, so intend to eliminate the dev branch by merging into main. Additional changes for .NET 8 can be made with PRs that target the main branch.

omajid commented 1 year ago

I will be merging these changes

LGTM!

tmds commented 1 year ago

Thanks for the review, @omajid!