redhat-developer / s2i-dotnetcore

.NET Core OpenShift images
Apache License 2.0
112 stars 192 forks source link

8.0: remove Node.js. #473

Closed tmds closed 1 year ago

tmds commented 1 year ago

Node.js was included since .NET Core 1.0 in our images because that was the front-end framework used by the .NET templates at the time and there was no .NET-based alternative available.

For .NET 8, the SDK no longer includes any Node.js-based templates, and the templates use Blazor for the front-end.

In line with these upstream changes, we are removing Node.js from the .NET 8 SDK image.

This is a breaking changes. Users migrating to the .NET 8 image that depend on Node.js will need to adjust their build. One option is to created an image derived from the .NET 8 image and install Node.js. Another option is to change to use a multi-stage build which builds the front-end in a separate stage, which may use the Node.js UBI images.

Fixes https://github.com/redhat-developer/s2i-dotnetcore/issues/384.

omajid commented 1 year ago

Should we update PATH too?

https://github.com/redhat-developer/s2i-dotnetcore/blob/57928777f13607fd78a4b52c40a45d63ff26adbe/8.0/build/Dockerfile.rhel8#L7