.NET 8: remove glibc-langpack-en package.

redhat-developer / s2i-dotnetcore

.NET Core OpenShift images

Apache License 2.0

112 stars 192 forks source link

.NET 8: remove glibc-langpack-en package. #482

Closed tmds closed 7 months ago

tmds commented 7 months ago

We've added this package to workaround an issue with MSBuild. The issue was fixed upstream for .NET 8.0.201, and we've backported that fix in our 8.0.1xx SDK.

tmds commented 7 months ago

The test_msbuild_exec_task test is passing with this change.

[INFO] Running test_msbuild_exec_task
...
---> Publishing application...
MSBuild version 17.8.5+b5265ef37 for .NET
  console -> /opt/app-root/src/bin/Release/net8.0/console.dll
  Running RunExecTask
  console -> /opt/app-root/app/
...

omajid commented 7 months ago

I am slightly worried that this may lead to regressions on the customer side if they are somehow making use of glibc-langpack-en some other way in their application container.

I am leaning towards merging this, but with the caveat that we should be ready to revert if anyone complains.