redhat-developer / service-binding-operator

[Deprecated] The Service Binding Operator: Connecting Applications with Services, in Kubernetes
https://redhat-developer.github.io/service-binding-operator
Apache License 2.0
109 stars 91 forks source link

ci: run security checks on push to branch #1482

Closed sadlerap closed 1 year ago

sadlerap commented 1 year ago

Changes

Recently in PRs, we've been getting warnings that our SAST tools don't have a known configuration for some branches. To fix this warning, we need to add push hooks for master and the release branches to run security checks.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

sadlerap commented 1 year ago

/hold

We should merge #1481 first to backport to the v1.4.x release series.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1482 (af66185) into master (44b0fa7) will not change coverage. Report is 4 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/redhat-developer/service-binding-operator/pull/1482/graphs/tree.svg?width=650&height=150&src=pr&token=CICBeVWlrC&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer)](https://app.codecov.io/gh/redhat-developer/service-binding-operator/pull/1482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) ```diff @@ Coverage Diff @@ ## master #1482 +/- ## ======================================= Coverage 58.16% 58.16% ======================================= Files 35 35 Lines 3014 3014 ======================================= Hits 1753 1753 Misses 1093 1093 Partials 168 168 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/redhat-developer/service-binding-operator/pull/1482?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/redhat-developer/service-binding-operator/pull/1482?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer). Last update [44b0fa7...af66185](https://app.codecov.io/gh/redhat-developer/service-binding-operator/pull/1482?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer).
sadlerap commented 1 year ago

/unhold

baijum commented 1 year ago

/lgtm /approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/service-binding-operator/blob/master/OWNERS)~~ [baijum] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment