Closed dkwon17 closed 1 year ago
Fixes https://github.com/redhat-developer/try-in-dev-spaces-browser-extension/issues/22
This PR adds a dropdown item that brings the user to the options page:
This PR also adds new scripts in package.json:
package.json
"build:firefox-safari": "cross-env TARGET=firefox-safari webpack --mode=development", "watch:firefox-safari": "yarn build:firefox-safari --watch",
used to build/watch the extension for use with Firefox/Safari.
This is because there are small differences in how things are defined in the V3 manifest. For our case:
browser_specific_settings
To test this PR:
On Google chrome,
yarn && yarn build
To test the new commands in this PR:
yarn build
dist/chromium
yarn build:firefox-safari
dist/firefox-safari
Fixes https://github.com/redhat-developer/try-in-dev-spaces-browser-extension/issues/22
This PR adds a dropdown item that brings the user to the options page:
Demo video:
https://user-images.githubusercontent.com/83611742/219819240-0669fbdf-ff49-4e6a-b275-0a4c44e5bb27.movThis PR also adds new scripts in
package.json
:used to build/watch the extension for use with Firefox/Safari.
This is because there are small differences in how things are defined in the V3 manifest. For our case:
browser_specific_settings
field causes a warning on Chromium based browsers. (This field is necessary for Firefox to use storage.sync api)To test this PR:
On Google chrome,
yarn && yarn build
and sideload the extensionTo test the new commands in this PR:
yarn build
and confirm that the extension is built indist/chromium
yarn build:firefox-safari
and confirm that the extension is built indist/firefox-safari