search

redhat-developer / try-in-dev-spaces-browser-extension

MIT License
0 stars 4 forks source link

Add project to factory url using url parameter #56

Closed dkwon17 closed 1 year ago

dkwon17 commented 1 year ago

This PR creates factory URLs in this format:

<che-host>/f?url=<git projectUrl>

instead of this format:

<che-host>/#<git project url>

To test this PR:

  1. Build and sideload the extension: https://github.com/redhat-developer/try-in-dev-spaces-browser-extension#building-and-running-locally
  2. Confirm that the 'Dev Spaces' button in GitHub can create workspaces
l0rd commented 1 year ago

Tested on both Safari and Chrome. In general I think that keeping the factory url parameter rather than the # is safer and we should keep it like that.

dkwon17 commented 1 year ago

Thanks @l0rd @ibuziuk , merging