redhat-developer / vscode-extension-tester

ExTester: Your Essential UI Testing Companion for Visual Studio Code Extensions! Seamlessly execute UI tests with Selenium WebDriver, ensuring robustness and reliability in your extension development journey. Simplify UI testing for your VS Code extensions and elevate the quality of your user interface effortlessly.
Apache License 2.0
258 stars 70 forks source link

Reverted dependabots update to got 14 since it requires node 20 #1252

Closed DavyLandman closed 5 months ago

DavyLandman commented 5 months ago

This reverts 20eb715 (#1197)

@dependabot upgraded to got 14, but that now requires node 20. ExTester has just moved to node18 (thanks for that), but as is explained in the readme, it's not ready for node20.

During install of the latest version of extester you would get this message:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'got@14.2.1',
npm WARN EBADENGINE   required: { node: '>=20' },
npm WARN EBADENGINE   current: { node: 'v18.19.1', npm: '10.2.4' }
npm WARN EBADENGINE }

So I thought to help out to make a PR with that dependency reverted, and maybe tell dependabot to not try to update this, the next time it comes around.

Before submitting your PR, please review the following checklist:

Before merging the PR:

djelinek commented 5 months ago

could you please do a rebase on main branch?

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud