build: Use Node 20 as default supported version

redhat-developer / vscode-extension-tester

ExTester: Your Essential UI Testing Companion for Visual Studio Code Extensions! Seamlessly execute UI tests with Selenium WebDriver, ensuring robustness and reliability in your extension development journey. Simplify UI testing for your VS Code extensions and elevate the quality of your user interface effortlessly.

Apache License 2.0

243 stars 67 forks source link

build: Use Node 20 as default supported version #1350

Closed djelinek closed 3 weeks ago

djelinek commented 3 weeks ago

mention Node 20 as supported in README.md file

Before submitting your PR, please review the following checklist:

[ ] CONSIDER adding a new test if your PR resolves an issue.
[ ] DO keep pull requests small so they can be easily reviewed.
[ ] DO make sure tests pass.
[ ] DO make sure any public APIs changes are documented.
[ ] DO make sure not to introduce any compiler warnings.

Before merging the PR:

[ ] CHECK continuous integration of main branch is green.
[ ] CHECK pull request check job is green.
[ ] CHECK all pull request questions/requests are resolved.
[ ] WAIT till PR is approved by at least 1 committer.

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

DavyLandman commented 3 weeks ago

@djelinek at the risk of becoming a broken record, but Selenium webdriver is still only supporting up to 18.8, with >18.8 as best effort ? Or is this meaning you've run tests and it seems to work fine?

djelinek commented 3 weeks ago

@djelinek at the risk of becoming a broken record, but Selenium webdriver is still only supporting up to 18.8, with >18.8 as best effort ? Or is this meaning you've run tests and it seems to work fine?

Hello @DavyLandman , I have decided to take a risk and go with already recommended Node 20 by VS Code. I know selenium-webdriver is still not fully supporting (..at least they did not updated docs yet..) but I feel it is worthy.

I have forget to add note into readme that we are still rather recommend to use Node 18, to be compliant also with selenium-webdriver, but ExTester will no more be logging warnings in console for Node > 18..

We are testing Node LTS and Latest for some time already and everything seems to be working just fine. You can check the status for those versions at NodeJS CI

DavyLandman commented 3 weeks ago

Good news 👍🏼