Reloading a window apprently clears Java project settings due to different workspace storage chosen - Githubissues

redhat-developer / vscode-java

Java Language Support for Visual Studio Code

Eclipse Public License 2.0

2.07k stars 433 forks source link

Reloading a window apprently clears Java project settings due to different workspace storage chosen #3671

Open nya3jp opened 3 months ago

nya3jp commented 3 months ago

Environment

Operating System: macOS (local host) + Linux (SSH remote host)
JDK version: 17.0.9
Visual Studio Code version: 1.89.1
Java extension version: 1.31.0

Steps To Reproduce

Open a large Java project on a remote machine with SSH remote development
Configure the Java project, e.g. add some source paths
Reload the window

Current Result

Configuration added in the step 2 is apparently lost.

Expected Result

Configuration added in the step 2 is kept.

Additional Informations

I found that the -data directory passed to jdt.ls differs before/after the reload.

Before: -data /usr/local/google/home/nya/.vscode-server/data/User/workspaceStorage/4f53a3d603ab9ba87f981c0821b0dc62/redhat.java/jdt_ws
After: -data /usr/local/google/home/nya/.vscode-server/data/User/workspaceStorage/4f53a3d603ab9ba87f981c0821b0dc62-1/redhat.java/jdt_ws

Notice the -1 suffix added to the workspace storage directory.

In fact, a VSCode extension may receive different context.storageUri for the identical workspace when multiple instances of VSCode opens the workspace concurrently (c.f. https://github.com/microsoft/vscode/issues/128234). This can happen even on a window reload because a storage directory lock is released only on the VSCode process exit (https://github.com/microsoft/vscode/blob/5f646b8e67a869ef33061085ffe0e377d5ba040c/src/vs/workbench/api/node/extHostStoragePaths.ts#L52).

I guess this problem happens only in remote development because VSCode skips obtaining locks for local extension hosts (https://github.com/microsoft/vscode/issues/128528).