search

redhat-developer / vscode-java

Java Language Support for Visual Studio Code
Eclipse Public License 2.0
2.05k stars 420 forks source link

Adopt the Lombok 1.18.33 edge release. #3674

Closed marco-belonio closed 2 weeks ago

marco-belonio commented 3 weeks ago

https://github.com/redhat-developer/vscode-java/issues/3561

blizzy78 commented 3 weeks ago

But edge != latest version?

sleberknight commented 3 weeks ago

From the Downloads page, it looks like you can use the generic link:

https://projectlombok.org/downloads/lombok.jar

I am assuming (but don't know for sure) that this link will always get the latest stable version. As of right now, that is 1.18.32 - the link text is Download 1.18.32

So maybe just need to use this link and then will always get the most recent stable version?

rgrunber commented 3 weeks ago

Thanks for getting this started. I remember when the original issue was filed but didn't see any progress for a long while.

Could you make the change look like the gulpfile at https://github.com/redhat-developer/vscode-java/commit/b59c43a2f7e5c2963084d8f7c6f55ade50e8cd02#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7 ? This won't require changing any runtime code. Instead of 1.18.31 (the unreleased version that "edge" was targetting then), call it 1.18.33.

If the edge release contains a fix, we can definitely adopt.

marco-belonio commented 2 weeks ago

@sleberknight The problem is, that the 1.18.32 does not work to resolve the problem :S

sleberknight commented 2 weeks ago

@sleberknight The problem is, that the 1.18.32 does not work to resolve the problem :S

Oops. Sorry! Clearly I missed that important part.