search

redhat-developer / vscode-java

Java Language Support for Visual Studio Code
Eclipse Public License 2.0
2.08k stars 438 forks source link

have vscode-java detect jbang installed jdks #3799

Open maxandersen opened 2 weeks ago

maxandersen commented 2 weeks ago

would like to have vscode-java function if it can pick up jdk's installed by vscode-java.

so that if user have jbang installed vscode-java will also "just work".

I see issues mention detection is done by node-jdk-utils so I made https://github.com/Eskibear/node-jdk-utils/pull/18 which should add the base detection.

But I'm also seeing src/findJavaRuntimes.ts which does not seem to use node-jdk-utils.

rgrunber commented 1 week ago

src/findJavaRuntimes was removed in #2246 (1.2.0). Is there some other extension you're seeing that still has that ?

maxandersen commented 1 week ago

@rgrunber probably just github / google search leading me a stray.

so would https://github.com/Eskibear/node-jdk-utils/pull/18 make it work in vscode-java ?

rgrunber commented 1 week ago

It should. Those jbang JDKs would be pick up through autodetection and sent to the language server.