Code action for static import doesn't work well in a specific case - Githubissues

redhat-developer / vscode-java

Java Language Support for Visual Studio Code

Eclipse Public License 2.0

2.08k stars 441 forks source link

Code action for static import doesn't work well in a specific case #3835

Open yuyully opened 3 weeks ago

yuyully commented 3 weeks ago

Environment

Operating System: Windows
JDK version: 17.0.8
Visual Studio Code version: 1.95.0
Java extension version: 1.36.0

Steps To Reproduce

Open https://github.com/junit-team/junit5-samples/tree/master/junit5-migration-maven
Open FirstTest.java file
Comment out import static org.junit.jupiter.api.Assertions.assertEquals;
Add import static org.junit.Assert.*;
Click quick fix before assertEquals

Current Result

It shouldn't show the option Add static import for 'Assert.assertEquals' as it has been included in import static org.junit.Assert.*;. And this option doesn't work if clicking it.
Without import static org.junit.Assert.*;, code action Add static import for 'Assert.assertEquals works only at first time. After first clicking, it still shows this option even the import has been added.

fbricon commented 3 weeks ago

Looks like the import detection mechanism doesn't consider the method signatures, hence proposes incompatible options