search

redhat-developer / vscode-openshift-tools

OpenShift extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=redhat.vscode-openshift-connector
MIT License
93 stars 59 forks source link

Start the "create an openshift cluster" wizard when calling the Deploy to Openshift command, if necessary #1849

Open fbricon opened 3 years ago

fbricon commented 3 years ago

If there's no cluster available, we want vscode-quarkus' "Deploy to Openshift" command to initiate the creation/configuration of the cluster. See https://github.com/redhat-developer/vscode-quarkus/pull/316#issuecomment-726870993

Screenshot 2020-11-13 at 17 44 00

Maybe "openshift.component.createFromRootWorkspaceFolder" is not suited for what we're trying to do, we might need a different command.

dgolovin commented 3 years ago

1844 is alike problem, when createFromRootWorkspaceFolder call triggers extension activation anything can happen:

  1. There might be no cluster current context at all
  2. Cluster can be running but not accessible
  3. User could be not logged in
  4. No projects in current cluster
  5. No app in current project

We can address 3, 4 and 5 by asking to login, provide project name and application name. That would keep workflow going.

For 1 and 2 we can initiate create/configuration of the cluster, but then folder deployment should be restarted manually.

@fbricon WDYT?

fbricon commented 3 years ago

but then folder deployment should be restarted manually.

why? What prevents you from storing the request?

fbricon commented 3 years ago

and what if we preset project name and application name with the project's artifactId? leaving a chance to the user to overwrite it?

dgolovin commented 3 years ago

but then folder deployment should be restarted manually.

why? What prevents you from storing the request?

Most likely it can be done. But considering time spend for starting CRC and then logging in to the cluster, request to enter application name would look a little unexpected and disconnected from original attempt to create component. I would be confused.

dgolovin commented 3 years ago

and what if we preset project name and application name with the project's artifactId? leaving a chance to the user to overwrite it?

That is something to check with odo team tomorrow during sync call. There was a discussion about that, but I am not sure if it was implemented.

mohitsuman commented 1 year ago

@dgolovin Let's discuss this in context of the latest workflow.