search

redhat-developer / vscode-openshift-tools

OpenShift extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=redhat.vscode-openshift-connector
MIT License
95 stars 61 forks source link

Fix issue opening Routes node in OpenShift explorer #4291

Closed fbricon closed 4 months ago

fbricon commented 4 months ago

When opening the Routes node of my DevSandbox cluster, I get this error:

Screenshot 2024-07-16 at 17 29 26 Screenshot 2024-07-16 at 17 35 57

This PR provides a naive fix for this issue, allowing my route to be displayed:

Screenshot 2024-07-16 at 17 44 09
fbricon commented 4 months ago

collectDeploymentErrors assumes the receiving object is a deployment. Naive fix => doesn't address route.status.ingress.conditions. Should it?

vrubezhny commented 4 months ago

route.status.ingress.conditions

What do you mean? (Sorry, can't find anything like this in main)

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.89%. Comparing base (da60441) to head (805ab3e). Report is 369 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4291 +/- ## =========================================== + Coverage 32.37% 43.89% +11.52% =========================================== Files 85 95 +10 Lines 6505 7716 +1211 Branches 1349 1635 +286 =========================================== + Hits 2106 3387 +1281 + Misses 4399 4329 -70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.