redhat-developer / vscode-quarkus

Quarkus Tools for Visual Studio Code, by Red Hat
https://quarkus.io
Apache License 2.0
72 stars 27 forks source link

Add Qute TexMate grammar to linguist project #463

Open rgrunber opened 2 years ago

rgrunber commented 2 years ago

https://github.com/github/linguist

See https://github.com/redhat-developer/vscode-quarkus/pull/430#discussion_r781928689 . This way all of GitHub can benefit from proper syntax highlighting.

AlexXuChen commented 2 years ago

According to the contributing guide:

"We try only to add languages once they have some usage on GitHub. In most cases we prefer that each new file extension be in use in at least 200 unique :user/:repo repositories before supporting them in Linguist."

~Do we have/know where to find any statistics on the number of Qute users using GitHub?~

UPDATE: I used the GItHub search results for the .qute extension: https://github.com/search?q=extension%3Aqute&type=code

The main issue is that Qute templates have html, json, txt and yaml extensions, so it is difficult to quantify on github.

rgrunber commented 2 years ago

Or maybe looking for projects with pom files that list the quarkus-resteasy-qute artifact in the pom or gradle build files.

https://mvnrepository.com/artifact/io.quarkus/quarkus-resteasy-qute doesn't seem to show much usage.

rgrunber commented 2 years ago

If the total number of search results is ~165 currently for instances of files (in repos) with the qute extension then we're definitely not above the 200 minimum limit when we group by repo. So for now this isn't going to happen but maybe we can reevaluate in the future.

Even with using the search API, I can maybe detect ~20 unique repositories that use a qute extension, but that API is heavily rate limited.