redhat-developer / vscode-redhat-telemetry

21 stars 25 forks source link

Enable prettier formatting #27

Open ssbarnea opened 1 year ago

ssbarnea commented 1 year ago
fbricon commented 1 year ago

can you add some instructions on how to trigger that new pre-commit hook?

ssbarnea commented 1 year ago

@fbricon Remember to also login to https://pre-commit.ci/ and authorize pre-commit app to run on this repository. While this is not required, it is the thing that enables two important features:

fbricon commented 1 year ago

I'm not fond of the python dependency. Can't we have 'npm lint' that calls prettier via nodejs?

I configured pre-commit app for this repo but don't understand why we need it if the CI build already calls pre-commit via npm lint

I'd be OK merging all the prettier config in this PR and discuss the pre-commit stuff in a separate one