search

redhat-developer / vscode-redhat-telemetry

21 stars 25 forks source link

Replace axios with NodeJS 18 `fetch()` #48

Open datho7561 opened 3 months ago

datho7561 commented 3 months ago

fetch() works in the browser as well as NodeJS as of NodeJS 18. This PR requires upgrading to NodeJS 18.

Signed-off-by: David Thompson davthomp@redhat.com

datho7561 commented 3 months ago

@fbricon if you have time and think it's okay to drop support for versions before NodeJS 18, could you please take a look at this PR?

fbricon commented 3 months ago

It also needs to work in a browser. If that's not broken then I m fine with that on principle. Will check when I get back.

datho7561 commented 3 months ago

Okay, thanks!