redhat-developer / vscode-rsp-ui

A unified UI for all RSP servers and RSP server-providers to integrate with
Eclipse Public License 2.0
39 stars 21 forks source link

Heads up: when clauses may be broken with the next VS Code release #264

Closed ulugbekna closed 1 year ago

ulugbekna commented 1 year ago

Hi 👋

VS Code team engineer here 🙂

We're reworking how we parse when clause contexts and noticed that we may break some of the when clauses used in your extension. You can read more in this issue, which describes upcoming changes: new features, breakages, and migration advice (latest VS Code Insiders now has a linter for when clauses and runs the new parser as default). You can also leave us feedback there.

Regexes on the right side of =~ don't need to be wrapped in single-quotes.

incorrect: view =~ '/(servers)/' correct: view =~ /(servers)/

Thanks for a great extension, it's very popular!

Best, Ulugbek

robstryker commented 1 year ago

Thanks for the heads up! I'll be looking into this ASAP!