search

redhat-developer / vscode-server-connector

📦 VS Code extension to run JBoss EAP servers and Runtimes
Eclipse Public License 2.0
57 stars 26 forks source link

[313] Error "Connection is closed" wont tell the user what exactly and why it failed #334

Closed lstocchi closed 5 years ago

lstocchi commented 5 years ago

it fixes #313

Signed-off-by: Luca Stocchi lstocchi@redhat.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #334 into master will decrease coverage by 0.23%. The diff coverage is 4.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   56.59%   56.35%   -0.24%     
==========================================
  Files          10       10              
  Lines         758      763       +5     
  Branches      161      164       +3     
==========================================
+ Hits          429      430       +1     
- Misses        329      333       +4
Impacted Files Coverage Δ
src/extension.ts 52.43% <4.76%> (-2.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc1fc22...6eb9e23. Read the comment docs.

adietish commented 5 years ago

immproves the errors niceley. Here's how the connection closed error is now displayed: image

adietish commented 5 years ago

@lstocchi can you please rebase this?

adietish commented 5 years ago

@lstocchi dare to please rebase this (again - required apparently since we merge your other PRs), please?