redhat-developer / vscode-server-connector

📦 VS Code extension to run JBoss EAP servers and Runtimes
Eclipse Public License 2.0
57 stars 26 forks source link

Identify read-only fields on editor when editing server properties #364

Open lstocchi opened 5 years ago

lstocchi commented 5 years ago

Currently there is no sign that identify which are the read-only fields in the editor when editing server properties. Users need to change their values and read the error displayed to know about it which is very annoying. We need to find a way to make their read-only attribute visible and clear.

Steps: ASSERT: have a wildfly server EXEC: pick "Edit Server" from ctx menu

Result: There's no way to know which are the read-only fields

adietish commented 5 years ago

I back this in the sense that I think that validating json as you type (as we provide currently) is not good enough. Ideally we'd also warn the user about the document structure, warning of unknown elements.

This could be achieved via a json schema. Further info is here:

We then can maybe auto-generate the schema and serve it via rsp-server.

@robstryker thoughts?

robstryker commented 5 years ago

Another suggestion could be a validateServerUpdate() API call instead? The vscode editor can call it any time there's been a period of inactivity? It could do all the same checks as updateServer but without actually updating?