redhat-developer / vscode-server-connector

📦 Connects Visual Studio Code to your server adapters and run, deploy apps !!
Eclipse Public License 2.0
57 stars 26 forks source link

Added tests for server properties editor (#358) #371

Closed lstocchi closed 5 years ago

lstocchi commented 5 years ago

it fixes #358

codecov[bot] commented 5 years ago

Codecov Report

Merging #371 into master will increase coverage by 3.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   53.24%   56.39%   +3.15%     
==========================================
  Files          13       13              
  Lines         879      883       +4     
  Branches      196      198       +2     
==========================================
+ Hits          468      498      +30     
+ Misses        411      385      -26
Impacted Files Coverage Δ
src/serverExplorer.ts 69.95% <100%> (+4.79%) :arrow_up:
src/serverEditorAdapter.ts 51.66% <100%> (+22.35%) :arrow_up:
src/extensionApi.ts 42.63% <0%> (+1.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1fb604...4e36272. Read the comment docs.

lstocchi commented 5 years ago

Moved issue/solution to https://github.com/redhat-developer/vscode-rsp-ui

lstocchi commented 5 years ago

This is the new PR on vscode-rsp-ui https://github.com/redhat-developer/vscode-rsp-ui/pull/8