search

redhat-developer / vscode-server-connector

📦 Connects Visual Studio Code to your server adapters and run, deploy apps !!
Eclipse Public License 2.0
57 stars 26 forks source link

Bad server labelling #425

Closed jeffmaury closed 4 years ago

jeffmaury commented 4 years ago

I noticed that EAP servers are labelled JBoss EAP xxx. I think we should rename them as Red Hat EAP xxx. Also EAP 7.3 is listed but EAP 7.3 is not yet GA so we should add a Preview or Beta qualifier

robstryker commented 4 years ago

It's a good idea, but, if you check https://www.redhat.com/en/technologies/jboss-middleware/application-platform it seems they use "JBoss EAP" more often than "Red Hat JBoss EAP". If we want confirmation here, we should ask the EAP team which name is most appropriate, and (if Red Hat is most appropriate) when they switched to that? We wouldn't want to (for example) rename JBoss 4.3 to "Red Hat JBoss 4.3".

I'm also concerned that we might eventually add an IBM to it ;) "IBM Red Hat JBoss EAP" starts to get a bit ridiculous =P

+1 for tech preview though

jeffmaury commented 4 years ago

https://developers.redhat.com/products/eap/overview

robstryker commented 4 years ago

Not sure I see your point. The first paragraph reads:

Overview

JBoss EAP is an open source platform for highly transactional, web-scale Java applications. EAP combines the familiar and popular Jakarta EE specifications with the latest technologies, like Microprofile, to modernize your applications from traditional Java EE into the new world of DevOps, cloud, containers, and microservices.

Note the lack of "Red Hat".

jeffmaury commented 4 years ago

Look at the main title and see the logo:

EAP

robstryker commented 4 years ago

Um... yeah I see that. My point is it's not used as often.

So far you provided 1 link, where "JBoss EAP" and "Red Hat JBoss EAP" were both used once each. I provided a link where "JBoss EAP" was used several times and "Red Hat JBoss EAP" was used only once.

I believe my point still stands.

jeffmaury commented 4 years ago

I think the main title rules and the logo, it's not being repeted like the CodeReady Studio docs where title has Red Hat CodeReady Studio and the rest of the text uses CodeReady Studio or CRS.

robstryker commented 4 years ago

issue replicated in JBT.

window -> preferences -> JBoss Tools / JBoss Runtime Detection -> click download button.

This is a problem in stacks.yaml and should be fixed there.

robstryker commented 4 years ago

vscode-server-connector_issue425

robstryker commented 4 years ago

https://github.com/jboss-developer/jboss-stacks/pull/132

robstryker commented 4 years ago

Should be fixed now jboss-developer/jboss-stacks#132