search

redhat-developer / vscode-server-connector

📦 Connects Visual Studio Code to your server adapters and run, deploy apps !!
Eclipse Public License 2.0
57 stars 26 forks source link

Terminating RSP provider wont kill the process #432

Closed odockal closed 4 years ago

odockal commented 4 years ago
  1. Have RSP running
  2. Terminate it
  3. ASSERT: RSP is stopped - ok
  4. ASSERT: RSP process is gone - fail: process is still alive and one cannot start RSP over, it says: 
    Unable to start the server: Extension backend error - rsp error - red hat server connector failed to start - workspace is locked. please verify workspace is not in use

Workaround: Kill rsp process manually. Then one can start rsp provider again.

robstryker commented 4 years ago

Please give more explanation as to how you are terminating it. Are you using the vscode UI to shut it down? Or are you kill -9 the process?

If you are kill -9 the process, there is absolutely no way for me to interrupt that and ensure all server adapters are shut down.

robstryker commented 4 years ago

I need more explanation here. I'm quite confused.

odockal commented 4 years ago

Sure, sorry. By terminating here, I mean RSP server provider context menu option - Terminate RSP Provider, available while rsp is started.

robstryker commented 4 years ago

opened https://github.com/redhat-developer/vscode-server-connector/pull/434 and https://github.com/redhat-developer/rsp-server-community/pull/23

Stupid mistakes.

robstryker commented 4 years ago

Both PRs closed / merged

odockal commented 4 years ago

Noice! Thanks!