search

redhat-developer / vscode-server-connector

📦 Connects Visual Studio Code to your server adapters and run, deploy apps !!
Eclipse Public License 2.0
56 stars 26 forks source link

Allow multiple configurations per server installation #530

Closed tarkin67 closed 7 months ago

tarkin67 commented 2 years ago

In our Wildfly setup we have multiple domain configurations per wildfly installation. The directory structure is the following:

%WILDFLY_HOME%\user_projects\domains\<domain_name>\configuration\standalone.xml image

With this setup the vscode-server-connector is basically useless, since it only allows for configuration files that are located within the %WILDFLY_HOME%\configuration directory.

The Wildfly server adaptor for Eclipse handles this much more elegantly by allowing to set a server home dir as well as a server base directory: image

It would be great to have something similar to this with the vscode-server-connector.

Please let us know your thoughts on this!

liechtir commented 2 years ago

Agree, same issue here.

liechtir commented 2 years ago

hi, any new on this? @robstryker @odockal @jrichter1

tarkin67 commented 2 years ago

Hi, any news? @robstryker @odockal @jrichter1

99sono commented 2 years ago

Hi There,

Yes, this feature is quite important. The wildly plugin deployment for eclipse does this very nicely.

In eclipse, we can have for each our projects a specific domain/stand alone folder. Within it, we have the standalone.xml configuration with the (port, queues, data sources, jta transaction timeout, etc...) that is appropriate for the specific project. Having a single standalone directory with multiple configuration files is not a good approach.

Please consider making sure that the features of the vscode plugin are on pair with the configuration possibilities of eclipse.

My recommendation would be to consider the wildfly plugin for eclipse as the gold standard. Any aspect that eclipse allows to tune (e.g. lunch parameters, standalone folder location, configuration file within the folder, etc...). Many thanks for having a look at this issue.

Kindest regards.

robstryker commented 2 years ago

Sorry, I was on parental leave. I'll try to dig in deeper as soon as I get settled.

liechtir commented 1 year ago

@robstryker congrats to the new dev in the team! did you find anything?

roiabanca commented 8 months ago

Is there any advance in this issue? In order to use vscode in an enterprise this functionallity must be inplemented

robstryker commented 7 months ago

Ok guys, really sorry for this. I got reassigned to some other stuff for a while. I worked on this today. It's not a huge patch, which makes me feel even worse for delaying this so long. I'll try to get it released ASAP.

RemoLiechti commented 7 months ago

Hi Rob, no worries, happens. Thanks for fixing it :-) Do you know any ETA? I will notify my former colleagues as I no longer work in that company.

robstryker commented 7 months ago

I merged it into rsp-server repo but not sure when I'll get a release done.

https://github.com/redhat-developer/rsp-server/pull/717