redhat-developer / vscode-xml

Editing XML in Visual Studio Code made easy
Eclipse Public License 2.0
262 stars 82 forks source link

[0.27.0] bad CPU type in executable on OSX (Intel) #1001

Closed alycklama closed 5 months ago

alycklama commented 5 months ago

I'm trying to run LemMinX 0.27.0 on Sonoma 14.4.1 (2,4 GHz 8-Core Intel Core i9), but I get the following error:

bad CPU type in executable

Version 0.26.1 works as expected.

angelozerr commented 5 months ago

@rgrunber @datho7561 have you some idea?

rgrunber commented 5 months ago

I think I see the problem :

$ file ./new/extension/server/lemminx-osx-x86_64
./new/extension/server/lemminx-osx-x86_64: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>

It wasn't "arm64" in 0.26.1 . That looks completely wrong. We should get to the bottom of it and produce a bug fix release.

Update: I don't yet see how, but the entire job to build the x64 bit binary server ran on an aarch64 runner :neutral_face:

Update 2: Maybe at https://github.com/redhat-developer/vscode-xml/pull/964/files#diff-b80496605edd832dcf2d81e352ad212e9ea5251b616374f061fdf03077050918R31-R35 macos-latest still was using 12 and we explicitly took 14 for aarch64. maybe that 'latest' silently changed, and we never noticed.

alycklama commented 5 months ago

Thanks for the lightning fast replies, and awesome to see you already found something! I know it's far too early, but If I can test anything, just let me know 👍

fbricon commented 5 months ago

@rgrunber according to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories, macos-latest runs on Mac M1s

rgrunber commented 5 months ago

@alycklama , this should be published as pre-release version 0.27.2024053103 . You can switch to pre-release from the VS Code extension view to try it. Let us know if it resolves the issue.

alycklama commented 5 months ago

@rgrunber I can confirm the issue is gone with the pre-release. Thanks a lot for the quick fix everyone!

angelozerr commented 5 months ago

@alycklama glad the issue has been fixed.

@rgrunber thanks so much!