search

redhat-developer / vscode-xml

Editing XML in Visual Studio Code made easy
Eclipse Public License 2.0
262 stars 82 forks source link

Formatter broken when use socks5 proxy #1005

Open Ksc0721 opened 6 months ago

Ksc0721 commented 6 months ago

According to Visual Code's http.proxy settings https://github.com/microsoft/vscode/blob/main/src/vs/platform/request/common/request.ts#L143

It could be "socks5://10.1.2.3:7777", and doesn't match vscode-xml's HOST_AND_PORT_EXTRACTOR https://github.com/redhat-developer/vscode-xml/blob/main/src/settings/proxySettings.ts#L155

In a word, it will produce a Cannot read properties of null (reading '1') exception, and the language client will not started.

angelozerr commented 6 months ago

Is there any chance to have a PR?

ivanbarsukov commented 4 months ago

Unfortunately, not only formatting, but the entire extension does not work if socks5 proxy is enabled