search

redhat-developer / vscode-xml

Editing XML in Visual Studio Code made easy
Eclipse Public License 2.0
262 stars 82 forks source link

Pull requests open #944

Open ejgutierrez74 opened 1 year ago

ejgutierrez74 commented 1 year ago

Hi, there are some Pull requests open, some of them from more than one year ago...it marks as WIP work in progress...but no review or conflict shown....Perhaps should take a decission, to approve or reject....No code added, or modified, or deleted, seems just waiting for something not known....

In special DTD extend grammar.

Thanks

angelozerr commented 1 year ago

In special DTD extend grammar.

This PR si for DTD textmate, do you need it?

ejgutierrez74 commented 1 year ago

Not me but perhaps other people...as i opened other bugs or enhancements to DTD, i thought could be a improvement...

TextMate is like Notapad++ or Sublime Text for Mac ? Or im wrong ? I dont understand then why a vscode extension has anything related to TextMate...

fbricon commented 1 year ago

the textmate grammar is a defacto standard, used in non-textmate editors. VS Code uses it : https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#tokenization

ejgutierrez74 commented 1 year ago

The main idea of the issue is to review the pull requests opened and give a solution..approve or reject....and not being in stand by by ages....

robstryker commented 1 year ago

it marks as WIP work in progress...but no review or conflict shown....

When a PR is marked as "Work-in-progress", it means the person developing the patch is not done and has not yet asked for a review.

Maintainers of any repository are unlikely to go review or test a patch when the author themselves are not confident enough in it to ask for a review.