redhat-developer / vscode-xml

Editing XML in Visual Studio Code made easy
Eclipse Public License 2.0
261 stars 82 forks source link

Use @vscode/vsce instead of vsce. #975

Closed rgrunber closed 8 months ago

rgrunber commented 8 months ago

Saw this in a build at the end of February.

Publishing 'redhat.vscode-xml (darwin-arm64) v0.26.2024022308'...
Extension URL (might take a few minutes): https://marketplace.visualstudio.com/items?itemName=redhat.vscode-xml
Hub URL: https://marketplace.visualstudio.com/manage/publishers/redhat/extensions/vscode-xml/hub
Published redhat.vscode-xml (darwin-arm64) v0.26.2024022308.
Publishing 'redhat.vscode-xml (darwin-x64) v0.26.2024022308'...
Version 0.26.2024022308 is already published. Skipping publish.
Publishing 'redhat.vscode-xml (linux-x64) v0.26.2024022308'...
Version 0.26.2024022308 is already published. Skipping publish.
Publishing 'redhat.vscode-xml (win32-x64) v0.26.2024022308'...
Version 0.26.2024022308 is already published. Skipping publish.
Publishing 'redhat.vscode-xml v0.26.2024022308'...
Version 0.26.2024022308 is already published. Skipping publish.

How could --skip-duplicate think a vsixs of other platforms with the same version are the same ? It's basically, https://github.com/microsoft/vscode-vsce/issues/868 and we just need to update vsce.

This is probably something we missed in https://github.com/redhat-developer/vscode-xml/pull/840/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R57 because the Jenkinsfile certainly had it correct.

fbricon commented 8 months ago

Thanks @rgrunber