search

redhat-developer / vscode-yaml

YAML support for VS Code with built-in kubernetes syntax support
MIT License
645 stars 219 forks source link

Consider Shipping Newer JSONSchema Version #704

Open DavidArchibald opened 2 years ago

DavidArchibald commented 2 years ago

As the README says:

YAML Language support uses JSON Schemas to understand the shape of a YAML file, including its value sets, defaults and descriptions. The schema support is shipped with JSON Schema Draft 7.

I would love to use features from a newer draft (specifically I'm looking at unevaluatedProperties though a lot of it is good). So shipping with the ability to use 2020-12 would be great! I tried looking around to see if there's any way to configure it to ship with a newer version or a reason why it would be, say, backwards incompatible and thus not implemented.

I tried searching the issues with the keyword jsonschema etc. so I hope this isn't a duplicate issue or answered somewhere obvious!

gorkem commented 2 years ago

This extension inherits JSON schema support from vscode-json-language-service. I think it is best to follow up on this issue or similar ones for this support.

DavidArchibald commented 2 years ago

Thank you for the swift reply! My apologies I was unsure if it was an upstream issue or not so thank you for the clarification.

RomuAdq commented 1 year ago

The unevaluatedProperties seems to work in JSON schema but not in yaml schema... Any idea of the problem ?

DetachHead commented 1 year ago

that issue has been fixed but this extension still does not seem to support unevaluatedProperties

pvanderlinden commented 4 months ago

This extension inherits JSON schema support from vscode-json-language-service. I think it is best to follow up on this issue or similar ones for this support.

@gorkem The upstream issue is resolved a while ago. But it still doesn't work for this plugin. Are there any plans to resolve this?

shuebner commented 2 months ago

@gorkem When will this be resolved?

gorkem commented 2 months ago

Unfortunately, I am not actively working on it.