search

redhat-developer / web-terminal-operator

OpenShift Console Web Terminal
MIT License
41 stars 15 forks source link

Add icon for Web Terminal Operator in OperatorHub #118

Closed amisevsk closed 2 years ago

amisevsk commented 2 years ago

What does this PR do?

Adds an icon for the operator when shown in the OpenShift UI. The icon used is the same as the terminal prompt icon that appears in the masthead once WTO is installed:

wto-icon-black-padding-2

wto-installed-icon

Note this icon has a transparent background, and since it is plain black, may look weird if OpenShift gets a dark mode for its UI.

What issues does this PR fix or reference?

N/A

Is it tested? How?

Build an bundle + index using the updated CSV and install the catalogsource in an OpenShift cluster. Note that the icon does not appear until the operator is installed. This may be due to using the legacy sqlite-based index format or due to using a custom catalogsource -- the icon is set in the same was we set it for the Che Operator.

amisevsk commented 2 years ago

The icon does not show up in the OperatorHub UI because the custom catalog's package collides with the default, and so this problem won't be present in the actual release:

wto-operatorhub-w-icon

amisevsk commented 2 years ago

I've updated the icon to have a white circle as the background (in case it is shown on a dark background) and added a bit more padding to make it smaller in context:

New icon: wto-icon-background-padded

In context in the UI:

new-wto-operatorhub new-wto-operatorhub-details new-wto-install new-wto-installed-operators new-wto-operator-details

For comparison, this is the CodeReady Workspaces icon in context:

crw-install