amisevsk
commented
2 years ago cc: @abhinandan13jan please test this out when you have a chance.
Closed amisevsk closed 2 years ago
amisevsk
commented
2 years ago cc: @abhinandan13jan please test this out when you have a chance.
abhinandan13jan
commented
2 years ago Not working for me on Mac
On Wed, Jun 8, 2022, 10:44 PM Ilya Buziuk @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/redhat-developer/web-terminal-operator/pull/122#pullrequestreview-1000149949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF5TQNVBH5IEJ64FE7DPBRTVODIFRANCNFSM5YBBZHOA . You are receiving this because you were mentioned.Message ID: @.*** com>
amisevsk
commented
2 years ago Commit https://github.com/redhat-developer/web-terminal-operator/pull/122/commits/9a78bcef6c2870db00c6e31509ba5334c5e7efe1 should work around the issue running on macOS, which uses a BSD version of sed from 2005. I'm unable to test though as I do not have access to macOS.
abhinandan13jan
commented
2 years ago Works like a Gem with 4.11
What does this PR do?
Fixes the
webterminal-localhost.shscript to make testing the OpenShift Console side of the Web Terminal Operator functionality easier. Required changes:sedreplacements for patching the Console frontend/backend were out of date; on the frontend we can no longer rely on the web-terminal-dev plugin, and instead have to disable TLS directly in the existing web-terminal-exec plugin via overrides. On the backend, we need to be careful about managing the URL to handlehttpsand the path added for basic routinginsecureEdgeTerminationPolicy: Redirect, your POST will be converted into a GET by the client-go library.What issues does this PR fix or reference?
Make it possible to use
webterminal-localhost.shto test the full WTO flow with debugging.Is it tested? How?
Tested by running the script.