search

redhat-developer / web-terminal-operator

OpenShift Console Web Terminal
MIT License
40 stars 15 forks source link

Upgrade `subctl` version #125

Closed Jaanki closed 2 years ago

Jaanki commented 2 years ago

Describe the bug

subctl version shipped with WTO 1.5 needs to be upgraded.

Expected Behavior

The version should be 0.12 or 0.13 (depending on how versions match with k8s/OCP).

Current Behavior

The current version is 0.10.1

Steps to Reproduce

  1. Open the web terminal
  2. Run subctl version 
    $ subctl version
subctl version: release-0.10-9680181

Environment

Cloud:

NOTE: Seen in AWS. But should be the same with other cloud providers.

OpenShift Version:

bash-4.4 ~ $ oc version
Client Version: 4.10.6
Server Version: 4.11.0-0.nightly-2022-06-15-222801
Kubernetes Version: v1.24.0+25f9057
Jaanki commented 2 years ago

subctl version has been updated to 0.12.1 in the next WTO image. Checked by running wtoctl set image quay.io/wto/web-terminal-tooling:next and then subctl version (as suggested on slack).

@amisevsk Thanks for taking care of this. :)

Also, a coorect subctl release repository is been watched to ensure that subctl is always updated with each release. OCP 4.11 is expected to have subctl 0.13.x. And hence closing it.

amisevsk commented 2 years ago

Thanks for opening the issue @Jaanki -- it turns out I didn't have notifications for this repo set up correctly and missed this issue until now. Issue is indeed fixed by https://github.com/redhat-developer/web-terminal-tooling/pull/44 and we will track subctl versions going forward.