search

redhat-developer / web-terminal-operator

OpenShift Console Web Terminal
MIT License
40 stars 15 forks source link

Make the error messages great again #65

Open pwright opened 3 years ago

pwright commented 3 years ago

Is your enhancement related to a problem? Please describe.

"Terminal is disabled for cluster-admin users" is buried in the error message, and the prompt 'Please try again' stands out

image

Describe the solution you'd like

Don't ask users to try again if they are doing something that isn't supported

Describe alternatives you've considered

Dont' present the web terminal icon in the console if I'm logged in as cluster admin

Additional context

The context is that i'm tired and didn't notice the exact message, and I kept trying again (was just doing what the console said to do!)

sleshchenko commented 3 years ago

OpenShift 4.7 is going to have the ability for cluster-admins to user terminals. So, this issue is just waits until WTO 1.2 is realeased

pwright commented 3 years ago

thanks @sleshchenko will there be an option to disable cluster-admin access?

sleshchenko commented 3 years ago

thanks @sleshchenko will there be an option to disable cluster-admin access?

that was not planned and as result not implemented. What is the reason to disable it for cluster admin?

pwright commented 3 years ago

Just thought that some folks might want to enable web terminal for developers and not for cluster-admin, but that might just be my imagination ;)