search

redhat-developer / yaml-language-server

Language Server for YAML Files
MIT License
1.1k stars 264 forks source link

Fix missing quote and syntax highlight in README #938

Open Legend-Master opened 1 year ago

Legend-Master commented 1 year ago

What does this PR do?

Fix some missing quotes and syntax highlighting in README

Before

image

After

image

coveralls commented 1 year ago

Coverage Status

coverage: 83.813%. remained the same when pulling affada7e6bcdb545aea6e15076136684df58faf7 on Legend-Master:readme-code-block-fix into ed03cbf71ade29ea62b4bcac0d8952195fd6969d on redhat-developer:main.

pierreprinetti commented 11 months ago

Hey @Legend-Master I am seeing this after posting #945.

Your solution is changing the examples to make them JSON, while I believe that they were written to be YAML. Can you please have a look at #945 and see if it makes sense?

Legend-Master commented 11 months ago

I think they're json files used by code editors, not yaml files (but since yaml contains/allows all json things, syntax highlighting should still works)

image

pierreprinetti commented 11 months ago

I think they're json files used by code editors, not yaml files

Oh! Interesting.

pierreprinetti commented 11 months ago

@gorkem PTAL