search

redhat-developer / yaml-language-server

Language Server for YAML Files
MIT License
1.06k stars 260 forks source link

feat: add extra data with solutionTitle to property completion #974

Open p-spacek opened 4 months ago

p-spacek commented 4 months ago

What does this PR do?

add data property (with schema title) to property completion items this extra info can be used later in the client

I tried to implement this inside the YLS, but the types don't correspond with vscode client, the unfinished implementation is here: https://github.com/redhat-developer/yaml-language-server/commit/54e817fd3a1243bf39ea0f8ac348b6d87290154d I can add this implementation into the YLS later, once the types will be solved

server types vs vscode types image image

example of usage:

image

What issues does this PR fix or reference?

Is it tested? How?

unit test

coveralls commented 4 months ago

Coverage Status

coverage: 84.179% (+0.005%) from 84.174% when pulling c5188d69789ef78157cf70f9f3c39eff2e8f5b58 on jigx-com:feat/add-extra-data-to-property-completion into 7203630540f35c88731bcf03ac41ca90b5919125 on redhat-developer:main.