WIP: Issue 151 Include :_module-type: variable into the template

[emmurphy1]

Issue 151 Include :_module-type: variable into the template

[mikemckiernan]

The change looks good, so formally, that is my approval.

That said:

• The module type is not customer-facing, or at least not compelling to make customer-facing. Ideally, we would not add this attribute to the docs.
• If the change must be made, I'd prefer that we amend the code to accept lowercase for the type.

I have the second bullet working in a playpen, but maven is misbehaving for me, so I have not submitted a PR. The gist is to change the foll line from "attValue.toString()" to "attValue.toString.toUpperCase()". https://github.com/redhataccess/pantheon/blob/master/pantheon-bundle/src/main/java/com/redhat/pantheon/asciidoctor/extension/MetadataExtractorTreeProcessor.java#L150 Do we want to hold off for a code change?

[rkratky]

@mikemckiernan,

formally, that is my approval

I suggest you use the GH "Review" functionality to record your approval.

I'd prefer that we amend the code to accept lowercase for the type

Agree, but that's a Pv2 matter (and as such, it should have no bearing on what happens in this repo).