Closed sterobin closed 2 years ago
@rkratky , good point. Done. Now monospaced. Thanks!
.
Hi!
How do I see the diagram? It seems that all links lead to the github issue.
Yehuda Zimmerman, RHCSA
Technical Writer III
Red Hat EMEA https://www.redhat.com/
@.*** M: +972-50-942-1156 IM: yzimmerm https://red.ht/sig
On Tue, Aug 17, 2021 at 6:58 PM Stetson Robinson @.***> wrote:
Section preview http://file.rdu.redhat.com/~sterobin/modular-docs-manual/master.html#nesting-assemblies (requires VPN)
You can view, comment on, or merge this pull request online at:
https://github.com/redhat-documentation/modular-docs/pull/168 Commit Summary
- Update nested assemblies diagrams.
File Changes
- A modular-docs-manual/images/nested-assemblies-correct.odt https://github.com/redhat-documentation/modular-docs/pull/168/files#diff-4f43f6b8f438cab18291c63d3858e4424fe9604af9532e08a8b8521a848c0c51 (0)
- M modular-docs-manual/images/nested-assemblies-correct.png https://github.com/redhat-documentation/modular-docs/pull/168/files#diff-66122dfb3a76d1190fff888e96d2843942d6878a4e2a71bc3d2f19a107616e8a (0)
- A modular-docs-manual/images/nested-assemblies-error.odt https://github.com/redhat-documentation/modular-docs/pull/168/files#diff-887733f850f188d29d5d40dde3511afe5c9507db3c6fb8e764f1839374479f66 (0)
- M modular-docs-manual/images/nested-assemblies-error.png https://github.com/redhat-documentation/modular-docs/pull/168/files#diff-a77e84446323975e83060e707bc859c3f3c073bb2011eed04adcf8c0ed37170f (0)
Patch Links:
- https://github.com/redhat-documentation/modular-docs/pull/168.patch
- https://github.com/redhat-documentation/modular-docs/pull/168.diff
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/redhat-documentation/modular-docs/pull/168, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG67PVMNGIJJV4KH7WMLKPDT5KBJHANCNFSM5CKFSWYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
@yzimmerm , preview link in the description. VPN required since it's in file share. Here again is the preview link from above for your convenience.
Which one? They all seemed to take me to git hub.
Yehuda Zimmerman, RHCSA
Technical Writer III
Red Hat EMEA https://www.redhat.com/
@.*** M: +972-50-942-1156 IM: yzimmerm https://red.ht/sig
On Wed, Aug 18, 2021 at 3:29 PM Stetson Robinson @.***> wrote:
@yzimmerm https://github.com/yzimmerm , preview link in the description.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redhat-documentation/modular-docs/pull/168#issuecomment-901072116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG67PVLW5CVUCMMS5SWIZ53T5ORR5ANCNFSM5CKFSWYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
@fbolton Right, understood. Thanks!
Addresses issue #110 . See section preview (requires VPN).
I ended up foregoing the Asciidoctor Diagram option because it was proving to be too cumbersome and limited, also unattractive. I instead just designed a simple diagram illustration in LibreOffice and included both the ODT source files and the final PNG files in the repo, so we don't run into this issue again.