search

redhat-documentation / modular-docs

Modular Documentation Project provides guidelines and examples for writing technical documentation using a modular framework.
Creative Commons Attribution Share Alike 4.0 International
82 stars 68 forks source link

A bunch of minor improvements and corrections #88

Closed mjahoda closed 5 years ago

adahms commented 5 years ago

@mjahoda - Thank you for the contribution!

Based on the above, it looks like there are two minor points that might need to be addressed before this pull request can be accepted.

Would you be able to take a look and update the PR accordingly?

mjahoda commented 5 years ago

Would you be able to take a look and update the PR accordingly?

@adahms I've updated the PR but I haven't incorporated the second comment by @jenmalloy. Please, feel free to delete the indefinite article before "explanation" if you also believe that it's better without it.

adahms commented 5 years ago

@mjahoda - Thanks for your reply, and sorry to keep you waiting!

I can see an argument in either direction, but the sentence is grammatically correct and conveys the intended meaning in its current format. Given that the change being discussed is a minor one - and that this pull request has been open for some time now - I am inclined to accept it so that we can incorporate the work you have done.

adahms commented 5 years ago

LGTM; merging.

All - please let me know if you feel additional work is required for this pull request and we'll investigate it in a separate branch.