search

redhat-documentation / modular-docs

Modular Documentation Project provides guidelines and examples for writing technical documentation using a modular framework.
Creative Commons Attribution Share Alike 4.0 International
82 stars 68 forks source link

Double quotes in templates and content #91

Closed VladimirSlavik closed 5 years ago

VladimirSlavik commented 5 years ago

Single quotes are intended to provide character substitutions and thus a wrong choice for IDs. This PR changes all single quotes in IDs to double quotes. There is no change to text and meaning, only the internals are technically correct after this change.

kalexand-rh commented 5 years ago

@adahms, what do you think? This could fix https://github.com/redhat-documentation/modular-docs/issues/87.

adahms commented 5 years ago

Thanks for the ping, @kalexand-rh!

I agree - the changes in this PR appear to address the central concern in that issue, and there are no outstanding instances of ' after these changes go through.

Looks good to me - you're welcome to merge if you like, but I can see there are some conflicts given the work that took place in between, and I can go through and resolve and merge those if you'd prefer. :)

kalexand-rh commented 5 years ago

@adahms, it depends on what your preferred workflow is. I don't have access to resolve the conflicts in the UI, but I'm happy to create a new PR based on @VladimirSlavik's changes and that addresses the conflicts.

adahms commented 5 years ago

@kalexand-rh - Resolved conflicts from the CLI and merged.

Closing PR.

VladimirSlavik commented 5 years ago

Thank you!