redhat-documentation / vale-at-red-hat

Vale config files, styles, and docs to help individuals and teams roll out Vale
https://redhat-documentation.github.io/vale-at-red-hat/
MIT License
39 stars 59 forks source link

Repetition rule gets thrown off at the end of a sentence? #321

Closed alexpdp7 closed 2 years ago

alexpdp7 commented 2 years ago

Describe the bug

Apparently, https://github.com/redhat-documentation/vale-at-red-hat/blob/main/.vale/styles/RedHat/RepeatedWords.yml gets thrown off at the end of a sentence.

Examples:

To Reproduce

Steps to reproduce the behavior:

  1. Just test the sentence above.
  2. Doesn't get flagged.

Expected behavior Should be flagged.

Additional context I haven't tested this with your full configuration- we use a different .vale.ini, so perhaps this doesn't happen with your full config (I fiddled a little bit copying token ignores, etc. from your .vale.ini and it was still a problem.

rolfedh commented 2 years ago

I confirmed that this issue is valid. The rule does not catch a repeated word at the end of a sentence like "This is a test test."

rolfedh commented 2 years ago

Some notes to share my process with others who might be interested in doing similar work: