rohennes
commented
6 months ago @aireilly - record rule fixes here as they come up?
Open rohennes opened 6 months ago
rohennes
commented
6 months ago @aireilly - record rule fixes here as they come up?
aireilly
commented
6 months ago Good idea. Fixed a few already.
aireilly
commented
6 months ago aireilly
commented
6 months ago aireilly
commented
6 months ago aireilly
commented
6 months ago rohennes
commented
6 months ago aireilly
commented
6 months ago rohennes
commented
6 months ago rohennes
commented
6 months ago rohennes
commented
6 months ago https://github.com/redhat-documentation/vale-at-red-hat/pull/748 kubelet stats receiver
aireilly
commented
6 months ago Https://github.com/openshift/openshift-docs/pull/73624/files#r1536274185 *.yaml should not trigger Vale errors
Update. Fixed in https://github.com/openshift/openshift-docs/pull/73624/files#diff-4848024b39d7cc167c5cce941ad1c5cf0a735dac853dc7c4a3486d66a216efecL25
rohennes
commented
6 months ago https://github.com/redhat-documentation/vale-at-red-hat/pull/750 - Removes Azure as an error term as too many false positives
aireilly
commented
6 months ago aireilly
commented
6 months ago aireilly
commented
6 months ago The VNIC/vNIC one is annoying. I think maybe a bug in Vale. We should create a test case and submit. Edit: https://github.com/errata-ai/vale/issues/802
Another variation seen here: https://github.com/openshift/openshift-docs/pull/66061#discussion_r1550265320
rohennes
commented
5 months ago https://github.com/openshift/openshift-docs/pull/74513 - fixes xrefs not getting flagged because of bad entry in accept.txt Vocab
aireilly
commented
5 months ago aireilly
commented
5 months ago Closed attribute block should not fire for JSON in a code block:
aireilly
commented
5 months ago Closed attribute block should not fire for JSON in a code block:
https://github.com/redhat-documentation/vale-at-red-hat/pull/777
Container issue to report bugs with the ocpdocs-vale-bot:
~~PPC flagged incorrectly: https://github.com/openshift/openshift-docs/pull/72761/files#r1532156043~~ (FIXED)
~~VT-d flagged incorrectly (?): https://github.com/openshift/openshift-docs/pull/72761#discussion_r1532155937~~ (FIXED)
~~- https://github.com/openshift/openshift-docs/pull/73626#discussion_r1535802857 https://github.com/openshift/openshift-docs/pull/72364#discussion_r1538905235 Use 'Kubelet' rather than 'Kubelet' Use 'VNIC' rather than 'VNIC'. Seems to be some issue with capitalization for suggestioned terms.~~ (FIXED)
https://github.com/openshift/openshift-docs/pull/73716#discussion_r1538293642 - Azure Blob Storage is a product name. I don't think we need to say Microsoft Azure Blob Storage. Azure Blob Storage is a feature of Microsoft Azure.(FIXED)Consider moving Azure to a warning as too many false positives, lots of product features with Azure only in the title. https://redhat-documentation.github.io/supplementary-style-guide/#azure "Always refer to it as "Microsoft Azure" to provide clarity unless the term is repeated multiple times in a sentence or paragraph." The guidance in the SSG is not rock solid either.(FIXED)https://github.com/openshift/openshift-docs/pull/72364#discussion_r1538905256 - edge case with commenting online outside of diff Further investigation, some sort of reproduction of this error here. If you move a file, then add error content to a line, which is followed by an unmodified line that also has a Vale error, Vale fires on the unmodified line. When I moved the file containing a Vale error, nothing happened. When I deleted a space on the line preceding the unmodified line with the Vale error, nothing happened. When I added a Vale error to the line preceeding the unmodified line with the Vale error, Vale flagged the unmodified line. Very edge case???
Can/should we exclude bold content? Bold content is usually for GUI labels? The vale-bot is flagging content the writer cannot change because it's in the GUI. For example: https://github.com/openshift/openshift-docs/pull/72364#discussion_r1567131998 See A-Z and number characters between s: `grep --include=.adoc -rnw . -e '*[A-Za-z0-9]\'`