redhat-documentation / vale-at-red-hat

Vale config files, styles, and docs to help individuals and teams roll out Vale
https://redhat-documentation.github.io/vale-at-red-hat/
MIT License
39 stars 59 forks source link

vCentre datacenter is an accepted term in OCP's VMWare implementation #824

Closed rohennes closed 4 months ago

rohennes commented 4 months ago

https://docs.openshift.com/container-platform/4.16/installing/installing_vsphere/ipi/ipi-vsphere-installation-reqs.html#installation-vsphere-installer-infra-requirements_ipi-vsphere-installation-reqs

vCenter datacenter is valid here

github-actions[bot] commented 4 months ago

Click here to review and test in web IDE: Contribute

github-actions[bot] commented 4 months ago

⚡️ Deploying PR Preview...

rohennes commented 4 months ago

@jeana-redhat - does this fix the issue that you mentioned in passing?

jeana-redhat commented 4 months ago

@jeana-redhat - does this fix the issue that you mentioned in passing?

well, upon more digging, I think maybe the sources we have gotten "datacenter" from in the past are either erroneous or outdated. Current VMware docs seems to have two words, lowercase ("data center") :upside_down_face:

aireilly commented 4 months ago

Argh. Merged this and didn't spot @jeana-redhat's comment. Is there more work we need to do here? Can you follow up with another PR if so. Sorry.

jeana-redhat commented 4 months ago

Argh. Merged this and didn't spot @jeana-redhat's comment. Is there more work we need to do here? Can you follow up with another PR if so. Sorry.

probably just a revert