search

redhat-documentation / vale-at-red-hat

Vale config files, styles, and docs to help individuals and teams roll out Vale
https://redhat-documentation.github.io/vale-at-red-hat/
MIT License
39 stars 59 forks source link

Correct AsciiDoc.ImageContainsAltText criteria #830

Closed sandbergja closed 4 months ago

sandbergja commented 4 months ago

If there are multiple entries in the raw array, they are concatenated into one large regular expression. In this case, this meant that we were searching for the regular expression image::.*\[\]image:.*\[\], which doesn't find images without alt text.

In this commit, we use a single regular expression that will match both cases: image with one colon, and image with two colons.

closes #829

github-actions[bot] commented 4 months ago

Click here to review and test in web IDE: Contribute

github-actions[bot] commented 4 months ago

⚡️ Deploying PR Preview...

aireilly commented 4 months ago

/lgtm

aireilly commented 4 months ago

Thank you for the PR @sandbergja :partying_face: