Closed Shreyanand closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Thanks for this! I just added a couple of minor comments about the code.
Fixes #4
It might also make #5 obsolete? Or at least partially - as it obtains basically the same data, probably in a cleaner form.
On the other hand, the obtained dataset does not include context, which is a problem for extractive QA. But I think that's fine if we focus on generative QA, where we'd also have to focus on other types of evaluation (beyond SQuAD).
It might also make #5 obsolete? Or at least partially - as it obtains basically the same data, probably in a cleaner form.
We could focus that PR for creating a validation data for extractive methods.
@codificat can we merge this if it looks good?
Fixes #23