Closed suppathak closed 11 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Thanks for the review @Shreyanand . I will address them in the next commit.
One thing we discussed earlier today was the option of adding a "human review" metric. Do we want to do that in this notebook before merging? Do you need collaboration for that?
Besides that, I would suggest editing the README in the notebooks and add an entry in the list of notebooks for this one.
There's also a merge conflict due to an updated Pipfile{.lock} in master
One thing we discussed earlier today was the option of adding a "human review" metric. Do we want to do that in this notebook before merging? Do you need collaboration for that?
Thanks @codificat . I would like to add "human evaluation metric" in this notebook. With this addition (which can act as a baseline metric), i think it would be easier to interpret other metrics. Having a collaboration for it is great. But first I think, we need to create some basic rules for evaluation. I am now trying to come up with some set of rules, which we can discuss in our sync-ups. Let me know wyt?
Besides that, I would suggest editing the README in the notebooks and add an entry in the list of notebooks for this one.
Sure!
There's also a merge conflict due to an updated Pipfile{.lock} in master
ok!! Thanks @codificat .
@suppathak What is pending here?
@suppathak What is pending here?
All good. Feel free to review it. Thank you @Shreyanand .
24