redhat-et / ilab-on-ocp

12 stars 16 forks source link

feat: use venv feature from KFP #129

Open leseb opened 1 week ago

leseb commented 1 week ago

a0aa0e1 feat: use venv feature from KFP

commit a0aa0e1b3d9647cdee904d7dd7b3c4c1a039bff3 Author: Sébastien Han seb@redhat.com Date: Tue Oct 29 18:06:45 2024 +0100

feat: use venv feature from KFP

Since this PR merged https://github.com/kubeflow/pipelines/pull/11326
let's consume it in our code to start testing.

Signed-off-by: Sébastien Han <seb@redhat.com>
leseb commented 2 days ago

I pushed more changes PTAL, I included an env override when using the RHELAI image, which is what the pipeline code will do soon.

cooktheryan commented 2 days ago

@leseb I'm somewhat reluctant to include this because I think we would want to ensure everything is already included in the container image that we produce. If an organization has specific firewalls setup they wouldn't be able to reach the external mirrors. I think this is completely a valid solution if we cannot get changes to the base RHEL AI image but we should go that direction first

leseb commented 2 days ago

@leseb I'm somewhat reluctant to include this because I think we would want to ensure everything is already included in the container image that we produce. If an organization has specific firewalls setup they wouldn't be able to reach the external mirrors. I think this is completely a valid solution if we cannot get changes to the base RHEL AI image but we should go that direction first

It's already too late for to include anything in 1.3 so we still have a quarter without it. That's why we need to do this temporary solution. The intention as noted in the code is too revert this logic once the RHELAI image gets the KFP package.

cooktheryan commented 2 days ago

This impacts the standalone script as well then I thought the PR was KFP specific

leseb commented 2 days ago

This impacts the standalone script as well then I thought the PR was KFP specific

This does not impact standalone. What makes you think it does?